Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alerts): Add incident title template support #2662

Merged
merged 9 commits into from
Aug 12, 2024
Merged

feat(alerts): Add incident title template support #2662

merged 9 commits into from
Aug 12, 2024

Conversation

baNROne
Copy link
Contributor

@baNROne baNROne commented May 17, 2024 •
edited by pranav-new-relic
Loading

A Note for Maintainers

⚠️ DO NOT MERGE this PR, until the changes in the New Relic Go Client PR linked below are merged and released
est. 12 Aug 2024 8AM PT

Description

https://new-relic.atlassian.net/browse/NR-74510
Note, this PR depends on unmerged changes in newrelic-go-client

Please do not merge yet

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

  • Must be on relevant FF
  • Must use this branch of newrelic-client-go
  • Incorporate incident_title_template into any newrelic_nrql_alert_condition
  • Plan and apply

@baNROne baNROne requested a review from akane0915 May 17, 2024 21:16
akane0915
akane0915 requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@akane0915 akane0915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and manual testing checks out. Can you please update the documentation here to include the new field? https://github.com/newrelic/terraform-provider-newrelic/blob/main/website/docs/r/nrql_alert_condition.html.markdown#L17

@baNROne baNROne requested a review from akane0915 May 20, 2024 20:50
@baNROne baNROne force-pushed the incident-title-template branch from 4090179 to 51d032a Compare May 20, 2024 20:52
akane0915
akane0915 previously approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@akane0915 akane0915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@baNROne baNROne mentioned this pull request May 20, 2024
Merged
@project0
Copy link

project0 commented Aug 8, 2024

can we get this done? I would like to use it :-).
I can also create a new PR if @baNROne has no time to finish it

@akane0915 akane0915 self-requested a review August 8, 2024 20:28
akane0915
akane0915 previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@akane0915 akane0915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@pranav-new-relic pranav-new-relic dismissed stale reviews from akane0915 and themself via 7f3a611 August 12, 2024 15:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.61%. Comparing base (92361de) to head (7f3a611).
Report is 98 commits behind head on main.

Files with missing lines Patch % Lines
...wrelic/structures_newrelic_nrql_alert_condition.go 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2662      +/-   ##
==========================================
+ Coverage   32.82%   36.61%   +3.79%     
==========================================
  Files          98       98              
  Lines       26884    21855    -5029     
==========================================
- Hits         8824     8002     -822     
+ Misses      17902    13690    -4212     
- Partials      158      163       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pranav-new-relic pranav-new-relic merged commit c519256 into newrelic:main Aug 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranav-new-relic pranav-new-relic pranav-new-relic approved these changes

@akane0915 akane0915 akane0915 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baNROne @project0 @codecov-commenter @akane0915 @pranav-new-relic